feat: implement column parallel for lm head to improve performance.#1145
Merged
XuZhang99 merged 3 commits intojd-opensource:mainfrom Apr 3, 2026
Merged
feat: implement column parallel for lm head to improve performance.#1145XuZhang99 merged 3 commits intojd-opensource:mainfrom
XuZhang99 merged 3 commits intojd-opensource:mainfrom
Conversation
wxh571001500
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the LmHead to utilize ColumnParallelLinearImpl and introduces support for vocabulary padding to ensure alignment during tensor parallel operations. The review feedback identifies several critical issues: a regression caused by hardcoding quantization arguments in a general-purpose linear layer constructor, memory inefficiencies when sharding padded tensors, and a potential bug in state dict lookups using incorrect keys. Additionally, there is a recommendation to deduplicate the vocabulary padding calculation logic into a shared utility to improve maintainability.
RobbieLeung
previously approved these changes
Mar 31, 2026
XuZhang99
reviewed
Mar 31, 2026
XuZhang99
approved these changes
Apr 1, 2026
DongheJin
pushed a commit
to DongheJin/xllm
that referenced
this pull request
Apr 3, 2026
DongheJin
pushed a commit
to DongheJin/xllm
that referenced
this pull request
Apr 3, 2026
DragonFive
pushed a commit
to DragonFive/xllm
that referenced
this pull request
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lmhead performance improved by 3%